Notify CSGPolygon about transform changes in Path3D

[xiongyaohua]

Fix #82024

Path3D notify transform change to CSGPolygon.

2023-11-28.10-58-22.mp4

[Chaosus]

Please amend the commit name to the actual PR name.

[xiongyaohua]

Please amend the commit name to the actual PR name.

done

[kleonc]

Does it need adding/exposing transform_changed signal? 🤔

It seems rather strange design-wise that specifically Path3D would have such signal given that transform is Node3D's property. I suggest production team reconsidering this API-wise before merging.

[xiongyaohua]

It seems rather strange design-wise that specifically Path3D would have such signal given that transform is Node3D's property.

Ideally the signal should be on Node3D, however according to this comment that will strongly hit performance, so I only add it to the Path3D to minimize impact. Of course if there is better way I can make change accordingly.

[YuriSizov]

Ideally the signal should be on Node3D, however according to this comment that will strongly hit performance, so I only add it to the Path3D to minimize impact.

I would say that given the comment you've linked, this is not an appropriate solution. We could probably add a way to hook a function pointer from the CSG shape into the path instead. That should be as cheap as doing the notification, performance wise, and won't expose anything to the API.

[AThousandShips]

Like how ViewPanner works, with some callback

[xiongyaohua]

Like how ViewPanner works, with some callback

done.

[akien-mga]

Thanks!