Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias platform=javascript SCons option to platform=web #84979

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 16, 2023

This makes build scripts backward-compatible, as was already done for other platforms that were renamed in 4.0.

@Calinou Calinou requested a review from a team as a code owner November 16, 2023 14:52
@Calinou Calinou added this to the 4.3 milestone Nov 16, 2023
@akien-mga
Copy link
Member

Looking at the logic for existing checks, it seems the macOS and iOS checks wrongly check for ios and macos being used. Those are already correct and they just get reassigned the same value, so they should simply not be a match.

We could consider refactoring that code a bit to use a dictionary of remappings, not sure if that would save lines of code though.

This makes build scripts backward-compatible, as was already done
for other platforms that were renamed in 4.0.
@Calinou
Copy link
Member Author

Calinou commented Nov 16, 2023

Looking at the logic for existing checks, it seems the macOS and iOS checks wrongly check for ios and macos being used. Those are already correct and they just get reassigned the same value, so they should simply not be a match.

Fixed.

@YuriSizov YuriSizov merged commit 718598e into godotengine:master Dec 20, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@Calinou Calinou deleted the scons-web-platform-alias branch January 8, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants