Move 2D-only and 3D-only navigation code to its own subfolder #83133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
2d-navigation
branch
from
abdb380
to
b5e7ee6
Compare
|
The same files for 3D are also not shared. I guess you would want to move them to their own 3D folder as well? |
aaronfranke
force-pushed
the
2d-navigation
branch
3 times, most recently
from
f34a230
to
f6b8b98
Compare
aaronfranke
changed the title
|
@smix8 Good idea, I did not realize those were fully independent. I have made the change. |
aaronfranke
force-pushed
the
2d-navigation
branch
from
f6b8b98
to
0aa07c3
Compare
aaronfranke
force-pushed
the
2d-navigation
branch
from
0aa07c3
to
09acb60
Compare
smix8
approved these changes
Jan 25, 2024
aaronfranke
force-pushed
the
2d-navigation
branch
from
09acb60
to
2e39401
Compare
aaronfranke
force-pushed
the
2d-navigation
branch
2 times, most recently
from
83733fb
to
1b51e32
Compare
aaronfranke
force-pushed
the
2d-navigation
branch
from
1b51e32
to
138180f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godot's navigation system works with both 2D and 3D. The 2D navigation code is essentially a wrapper for the 3D navigation system. This PR moves the 2D navigation files into their own subfolder, making it clear what's just for 2D and what is shared between 2D and 3D. This is consistent with the
scene/2dfolder having 2D nodes.