Add negative index to Array.remove_at and Array.insert
#83027
+46
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chubercik
reviewed
Oct 9, 2023
Chubercik
reviewed
Oct 9, 2023
rarysson
force-pushed
the
array-negative-indexes
branch
from
6e45eea
to
dcf9448
Compare
Chubercik
approved these changes
Oct 10, 2023
|
Please squash the commits into a single one as described in the PR workflow. |
rarysson
force-pushed
the
array-negative-indexes
branch
from
97112e9
to
c110a3e
Compare
Chubercik
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #46947 (and here #37209 (comment)) and address godotengine/godot-proposals#4637.
If the user can use negative indexes for
array[-1]andarray.pop_at(-1), for consistency, adding the same feature toArray.remove_atandArray.insertseems ideal.