Remove lgtm.yml since LGTM is now replaced by Github Code Scanning #81874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM has been acquired by Github, and all its features is replaced by Github Code Scanning. So seems .lgtm.yml is no longer used.
Calinou
added
the
cherrypick:4.1
aaronfranke
changed the title
YuriSizov
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Looks like we should've done this alongside #66714.
If we want to use code scanning, we need to create a workflow for it with GitHub Actions. But it looks like the only reason we have a config is because we've had the badge and it wasn't building correctly (#41739). So for now, removing it seems fine.
PS. Should probably cherry-pick into the 4.0 branch as well. 3.x seems to be unaffected (we had a badge there, but not the config).
YuriSizov
added
the
cherrypick:4.2
|
Thanks! |
|
Cherry-picked for 4.2.2. |
YuriSizov
added
topic:buildsystem
and removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LGTM has been acquired by Github, and all its features is replaced by Github Code Scanning.
So seems .lgtm.yml is no longer used.
Detailed Github announcement here