Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix input handling for unfocusable embedded windows #77842

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix input handling for unfocusable embedded windows #77842

merged 1 commit into from
Jun 8, 2023

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Jun 4, 2023 •
edited
Loading

resolve #53501

fix that InputEvents get in some cases sent to the wrong Window.
fix Viewport::_sub_windows_forward_input- console error spam

@YuriSizov YuriSizov added this to the 4.x milestone Jun 6, 2023
@Sauermann
Fix input handling of unfocusable embedded Windows
f00f4a0 
InputEvents get in some cases sent to the wrong Window.
fix `Viewport::_sub_windows_forward_input`- console error spam
@Sauermann Sauermann marked this pull request as ready for review June 6, 2023 16:33
@Sauermann Sauermann requested a review from a team as a code owner June 6, 2023 16:33
RandomShaper
RandomShaper reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, it corrects the fact that the concepts of focused and dragged window were being conflated, applying now the relevant logic to each of those. Is that fair?

@Sauermann
Copy link
Contributor Author

Yes, that summary captures the essence of this PR.

RandomShaper
RandomShaper approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akien-mga akien-mga modified the milestones: 4.x, 4.1 Jun 8, 2023
@akien-mga akien-mga merged commit 3a19d81 into godotengine:master Jun 8, 2023
@akien-mga
Copy link
Member

Thanks!

@Sauermann Sauermann deleted the fix-unfocusable-subwindow branch June 8, 2023 15:39
This was referenced Jun 11, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

@bruvzg bruvzg Awaiting requested review from bruvzg

Assignees
No one assigned
Labels
bug topic:gui topic:input
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Unfocusable embedded windows aren't used for input handling
4 participants
@Sauermann @akien-mga @RandomShaper @YuriSizov