Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose method to set a project setting as internal #77668

Merged
merged 1 commit into from
May 31, 2023
Merged

Expose method to set a project setting as internal #77668

merged 1 commit into from
May 31, 2023

Conversation

winston-yallow
Copy link
Contributor

This makes it possible to set custom project settings as internal.
Closes godotengine/godot-proposals#6984

@winston-yallow winston-yallow requested review from a team as code owners May 30, 2023 19:22
@Calinou Calinou added this to the 4.x milestone May 31, 2023
YuriSizov
YuriSizov approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@YuriSizov YuriSizov modified the milestones: 4.x, 4.1 May 31, 2023
@YuriSizov YuriSizov merged commit aefc468 into godotengine:master May 31, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@winston-yallow winston-yallow deleted the expose-marking-project-settings-internal branch May 31, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Expose method to set a project setting as internal
4 participants
@winston-yallow @YuriSizov @RandomShaper @Calinou