Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally free GI and FOG resources, they may not have been created #77327

Merged
merged 1 commit into from
May 22, 2023

Conversation

BastiaanOlij
Copy link
Contributor

Depending on the renderer use, GI and FOG may not be (fully) initialised as parts are not supported (specifically with the mobile renderer but this may be applicable to other renderers in the future).

We thus need to only free those resources that we're initialised.

This prevents some error spam when Godot closes.

@akien-mga akien-mga merged commit d5c1b9f into godotengine:master May 22, 2023
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_gi_and_fog_free branch May 22, 2023 23:24
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants