Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent file dialog settings usage #76421

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

timothyqiu
Copy link
Member

Currently, editor settings about file dialogs are not correctly applied in some cases:

  • Default display mode and show hidden files settings are not updated when corresponding editor settings change. So EditorFileDialogs created on-demand won't use the updated settings.
  • Project Manager ignores display mode settings.

* Project Manager ignores display mode settings.
* EditorFileDialog's default display mode and show hidden files settings
  are not updated when corresponding editor settings change.
@timothyqiu timothyqiu added this to the 4.1 milestone Apr 25, 2023
@timothyqiu timothyqiu added cherrypick:3.x Considered for cherry-picking into a future 3.x release and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 25, 2023
@akien-mga akien-mga merged commit e54ebaf into godotengine:master Apr 25, 2023
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the editor-dialog branch April 25, 2023 08:56
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants