Properly update nodepath with batch rename #76376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
changed the title
ajreckof
force-pushed
the
fix_NodePath_update_from_batch_rename
branch
from
33cb450
to
a8dee4a
Compare
ajreckof
force-pushed
the
fix_NodePath_update_from_batch_rename
branch
from
a8dee4a
to
7f56b21
Compare
|
This PR introduces changes to the UndoRedo system. I think they are fine, but IMO they should be moved to a separate PR and the new arguments need to be documented. |
@KoBeWi From the PR description:
🙃 |
|
🙃 |
|
Can be rebased now that the dependent PR has been merged. |
ajreckof
force-pushed
the
fix_NodePath_update_from_batch_rename
branch
from
7f56b21
to
ba6e8e6
Compare
|
Rebased. |
ajreckof
force-pushed
the
fix_NodePath_update_from_batch_rename
branch
from
ba6e8e6
to
263c356
Compare
|
UndoRedo does not work anymore with batch rename. |
ajreckof
force-pushed
the
fix_NodePath_update_from_batch_rename
branch
from
263c356
to
5c15083
Compare
|
Yeah I think I messed up the rebase which made the |
KoBeWi
approved these changes
Jun 14, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76070
Fixes #76680
partially fixes #76679 (gives a warning after rename with invalid character but does not print a warning on the batch rename dialog box)
This changes the way undo redo was handled so that
prerenamesignal is triggered just before the actual rename and not all at once at the start. This is important as prerename needs previous rename to have done so that Nodepath are valid.Edit : this goes a bit further than the original commit as it was lacking in some places. It places in
_rename_nodeeverything that was in_renamedand would also apply for batch rename. This includes :node_prerenameUnfortunatly this need this other PR #76688 to be merged first (it was added as first commit here as it is needed)