Add the ability to look-at in model-space. #76082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
force-pushed
the
ability-to-look-at-in-model-space
branch
from
9e67ae3
to
59f98d6
Compare
|
If it is an alternative to #76060, then it need to add an option to |
|
Looks like a more reasonable PR. Introducing breaking changes at that level would not only break projects, but addons too. We could maybe introduce too |
@reduz Why not |
|
@adamscott The rationale for the model constants is that this is what you see in the 3D application (both Godot and any other). In other words, for a 3D model, forward is not a convention but artists just do it this way because its more practical due to how modelling apps work. What is a convention is that this is the front view of the model, hence the constant names. |
TokageItLab
force-pushed
the
ability-to-look-at-in-model-space
branch
2 times, most recently
from
a877729
to
c98fc67
Compare
TokageItLab
force-pushed
the
ability-to-look-at-in-model-space
branch
2 times, most recently
from
d308592
to
72e0dc4
Compare
This is a much simpler attempt to solve the same problem as godotengine#76060, but without breaking any compatibility. * Adds a description of what model space is in the Vector3 enums (MODEL_* constants). This has the proper axes laid out for imported 3D assets. * Adds the option to `look_at` using model_space, which uses Vector3.MODEL_FRONT as forward vector. The attempt of this PR is to still break the assumption that there is a single direction of forward (which is not the case in Godot) and make it easier to understand where 3D models are facing, as well as orienting them via look_at.
TokageItLab
force-pushed
the
ability-to-look-at-in-model-space
branch
from
72e0dc4
to
5fdc123
Compare
|
Thanks! |
geowarin
added a commit
to geowarin/godot
that referenced
this pull request
Jul 6, 2023
To LookAt methods. Also adds Vector3 Model constants. These were not added after godotengine#76082 was merged.
suinswofi
pushed a commit
to suinswofi/godot
that referenced
this pull request
Jul 20, 2023
To LookAt methods. Also adds Vector3 Model constants. These were not added after godotengine#76082 was merged.
IntangibleMatter
pushed a commit
to IntangibleMatter/godot
that referenced
this pull request
Aug 13, 2023
To LookAt methods. Also adds Vector3 Model constants. These were not added after godotengine#76082 was merged.
YuriSizov
pushed a commit
to YuriSizov/godot
that referenced
this pull request
Aug 31, 2023
To LookAt methods. Also adds Vector3 Model constants. These were not added after godotengine#76082 was merged. (cherry picked from commit 6c6e5c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much simpler attempt to solve the same problem as #76060, but without breaking any compatibility, based on the feedback gathered yesterday.
look_atusing model_space, which uses Vector3.MODEL_FRONT as forward vector.The attempt of this PR is to still break the assumption that there is a single direction of forward (which is not the case in Godot) and make it easier to understand where 3D models are facing, as well as orienting them via look_at.