Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sky luminance scaling to before fog is applied #75812

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Move sky luminance scaling to before fog is applied #75812

merged 1 commit into from
Apr 11, 2023

Conversation

RandomCatDude
Copy link
Contributor

Fixes #74370 by moving the sky luminance multiplier (AKA Background Energy) to before fog is integrated, so that fog isn't erroneously affected by it.

Before:
image

After:
image

@RandomCatDude RandomCatDude requested a review from a team as a code owner April 8, 2023 08:01
@YeldhamDev YeldhamDev added this to the 4.x milestone Apr 8, 2023
@akien-mga akien-mga merged commit ef17794 into godotengine:master Apr 11, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov modified the milestones: 4.x, 4.1 Apr 11, 2023
@RandomCatDude RandomCatDude deleted the sky-fog-luminance-fix branch April 11, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Background energy multiplier affects fog rendering
6 participants
@RandomCatDude @akien-mga @Calinou @clayjohn @YuriSizov @YeldhamDev