Implement vertical icon alignment for buttons #74369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Apr 29, 2023
KoBeWi
approved these changes
Apr 29, 2023
|
Needs rebase. |
|
@KoBeWi Done |
Maran23
reviewed
May 4, 2023
| @@ -58,7 +58,7 @@ | |||
| To edit margin and spacing of the icon, use [theme_item h_separation] theme property and [code]content_margin_*[/code] properties of the used [StyleBox]es. | |||
| </member> | |||
| <member name="icon_alignment" type="int" setter="set_icon_alignment" getter="get_icon_alignment" enum="HorizontalAlignment" default="0"> | |||
There was a problem hiding this comment.
I guess a better name is horizontal_icon_alignment, but to keep backwards compatibility it is better to not touch it.
Still maybe an idea in the future.
Maran23
approved these changes
May 4, 2023
mhilbrunner
approved these changes
May 5, 2023
|
Thanks! |
|
What is the expected behavior of those
When |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons already support aligning the icon to the left/right of the text. However this is a bit limiting, as it may also be desired to have the text above/below the icon.
This PR therefore adds the option to align the icon vertically by adding a
vertical_icon_alignmentproperty to the button class.Here is an example image showing all combinations:
Here's the same image with
expand_iconturned on:Feel free to test the button behavior on my test project:
vertical_button_test.zip