Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial fixes for threading/worker_pool/max_threads = 0 #72704

Merged
merged 1 commit into from
May 12, 2023
Merged

Partial fixes for threading/worker_pool/max_threads = 0 #72704

merged 1 commit into from
May 12, 2023

Conversation

myaaaaaaaaa
Copy link
Contributor

Includes a partial fix for some issues that come up when threading/worker_pool/max_threads is set to 0.

@myaaaaaaaaa myaaaaaaaaa requested a review from a team as a code owner February 4, 2023 05:03
@Chaosus Chaosus added this to the 4.0 milestone Feb 6, 2023
@myaaaaaaaaa myaaaaaaaaa changed the title Run tasks on the main thread in single-threaded mode Run WorkerThreadPool tasks on the main thread when in single-threaded mode Feb 10, 2023
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 17, 2023
@clayjohn
Copy link
Member

cc @RandomShaper

@myaaaaaaaaa myaaaaaaaaa changed the title Run WorkerThreadPool tasks on the main thread when in single-threaded mode Partial fixes for threading/worker_pool/max_threads = 0 May 11, 2023
@myaaaaaaaaa myaaaaaaaaa mentioned this pull request May 12, 2023
Merged
@akien-mga akien-mga merged commit 20ed51a into godotengine:master May 12, 2023
@akien-mga
Copy link
Member

Thanks!

@myaaaaaaaaa myaaaaaaaaa deleted the single-main-thread branch May 12, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@myaaaaaaaaa @clayjohn @akien-mga @RandomShaper @Chaosus @YuriSizov