Avoid updating particles during 2D rendering #70457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2D the particle uniform set isn't obtained until the render pass. So in 2D just avoid rendering if not updated yet.
akien-mga
approved these changes
Dec 23, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #70431
tested with the MRPs from: #56691, #59072, #65443, #70431, and a few others I had on hand
This maintains the same behaviour for 3D (i.e. particles can be used the first frame that they are added to the scene), but for 2D we have to wait until the next frame. Particle update is requested so the particles will be updated before they are drawn again. This is necessary because in 2D the uniform set is not grabbed until rendering has started and you can't run a compute shader program while rendering is going on.
This bug didn't trigger when adding particles via the editor as they would get updated before drawing (i.e. at scene loading time).