Add editor settings for autocompletion with NodePath and StringName #66481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
auto-stringname-nodepath
branch
2 times, most recently
from
d09451a
to
9a1f33b
Compare
Paulb23
previously requested changes
Oct 4, 2022
MewPurPur
force-pushed
the
auto-stringname-nodepath
branch
from
9a1f33b
to
1cbbaf4
Compare
|
Messed up the rebase....... Edit: Ok I think I didn't nuke my PR while trying to fix it. Should be good again? |
MewPurPur
force-pushed
the
auto-stringname-nodepath
branch
11 times, most recently
from
6d75275
to
d2aba36
Compare
MewPurPur
force-pushed
the
auto-stringname-nodepath
branch
from
d2aba36
to
5da70c6
Compare
KoBeWi
reviewed
Dec 2, 2022
KoBeWi
approved these changes
Dec 2, 2022
MewPurPur
force-pushed
the
auto-stringname-nodepath
branch
from
5da70c6
to
74b8fa3
Compare
|
May I poke in? This PR has been good for a whole year and it's only missing @Paulb23 's approval and a conflict merge. |
akien-mga
approved these changes
Jan 4, 2024
|
This feature was suggested by Calinou in another PR, hence my poking. |
|
I'd like to ping @Paulb23 one more time for good measure to make sure there are no issues with the PR as is (minus the fact that it needs to be rebased again) |
akien-mga
reviewed
Mar 1, 2024
|
If this feature is desired, apart from a rebase, updated changes look okay to me. |
MewPurPur
force-pushed
the
auto-stringname-nodepath
branch
from
74b8fa3
to
178305f
Compare
MewPurPur
force-pushed
the
auto-stringname-nodepath
branch
from
178305f
to
de8b6f7
Compare
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
Add editor settings for autocompletion with NodePath and StringName
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#5496
This is built into the autocompletion algorithm – if you're in a function and autocompletion gives a string, it checks whether the editor setting is on. If it is, it adds the literals
&or^as prefixes, based on if the argument is a NodePath or a StringName. Works in any situation, no adaptation is needed to specific functions.autocomplete.stonks.mp4