Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering when using WebGL2 #65442

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Sep 6, 2022

Fixes: #65304
Fixes: #64453

Fixes 3D rendering in WebGL2 and 2D rendering. I can now run the web-based project manager

Screenshot from 2022-09-06 14-44-30

There isn't an option to create a project using OpenGL3 yet, so I haven't tested running a project yet.

Fixes include:

  1. Using proper depth buffer format in 3D (this had previously been fixed already in Fix various bugs in GLES3 renderer that stopped it from running on web #63794 but the changes were lost in a rebase of Extracting render buffers and changing it to a more generic solution #63901),
  2. Remove unused lighting and shadowing code in 2D, and
  3. Update 2D UBOs using glBufferSubData so that they remain the appropriate size.

cc @dsnopek

Fixes include using proper depth buffer format in 3D (this had previously been fixed already but the changes were lost in a rebase), Remove unused lighting and shadowing code in 2D, and update 2D UBOs using glBufferSubData so that they remain the appropriate size.
@dsnopek
Copy link
Contributor

dsnopek commented Sep 6, 2022

I just tested this PR with my test projects from #65304 and #64453 - it works great!

@akien-mga akien-mga merged commit 6f47f16 into godotengine:master Sep 7, 2022
@akien-mga
Copy link
Member

Thanks!

@clayjohn clayjohn deleted the GLES3-HTML5-fixes branch September 7, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants