Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange editor/naming/* project settings #65137

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Aug 31, 2022

1. Renamed the following project settings:

Before After
editor/scene/scene_naming editor/naming/scene_name_casing
editor/node_naming/name_num_separator editor/naming/node_name_num_separator
editor/node_naming/name_casing editor/naming/node_name_casing

2. The following editor settings replaced with project settings:

Before After
interface/editors/default_signal_callback_name editor/naming/default_signal_callback_name
interface/editors/default_signal_callback_to_self_name editor/naming/default_signal_callback_to_self_name

Notes:

1. The project settings from the editor section should be moved to Editor Settings, but with the ability to override them for the project.

2. The setting editor/naming/scene_name_casing may need to be changed to editor/naming/file_name_casing (not only scene files should use this setting, but other resource types as well). See #57768.

3. I found that doc generation does not work for all project settings. It depends on the file where the setting is defined with GLOBAL_DEF:

  • core/config/project_settings.cpp - ok
  • editor/editor_file_system.cpp - error
  • editor/editor_node.cpp - error
  • editor/export/editor_export_plugin.cpp - error
  • editor/plugins/version_control_editor_plugin.cpp - error
  • scene/main/node.cpp - ok
  • servers/movie_writer/movie_writer.cpp - ok
Details
GLOBAL_DEF("editor/

core/config/project_settings.cpp: 4
1223:  2: 	GLOBAL_DEF("editor/run/main_run_args", "");
1225:  2: 	GLOBAL_DEF("editor/script/search_in_file_extensions", extensions);
1228:  2: 	GLOBAL_DEF("editor/script/templates_search_path", "res://script_templates");
1232:  2: 	GLOBAL_DEF("editor/naming/default_signal_callback_name", "_on_{node_name}_{signal_name}");
editor/editor_file_system.cpp: 2
2416: 39: 	reimport_on_missing_imported_files = GLOBAL_DEF("editor/import/reimport_missing_imported_files", true);
2417:  2: 	GLOBAL_DEF("editor/import/use_multiple_threads", true);
editor/editor_node.cpp: 1
5947:  2: 	GLOBAL_DEF("editor/naming/scene_name_casing", SCENE_NAME_CASING_SNAKE_CASE);
editor/export/editor_export_plugin.cpp: 1
200:  2: 	GLOBAL_DEF("editor/export/convert_text_resources_to_binary", false);
editor/plugins/version_control_editor_plugin.cpp: 3
 95: 29: 		String installed_plugin = GLOBAL_DEF("editor/version_control/plugin_name", "");
 96: 25: 		String project_path = GLOBAL_DEF("editor/version_control/project_path", OS::get_singleton()->get_resource_dir());
 98: 30: 		bool has_autoload_enable = GLOBAL_DEF("editor/version_control/autoload_on_startup", false);
scene/main/node.cpp: 2
2785:  2: 	GLOBAL_DEF("editor/naming/node_name_num_separator", 0);
2787:  2: 	GLOBAL_DEF("editor/naming/node_name_casing", NAME_CASING_PASCAL_CASE);
servers/movie_writer/movie_writer.cpp: 3
134:  2: 	GLOBAL_DEF("editor/movie_writer/mix_rate", 48000);
136:  2: 	GLOBAL_DEF("editor/movie_writer/speaker_mode", 0);
138:  2: 	GLOBAL_DEF("editor/movie_writer/mjpeg_quality", 0.75);

@KoBeWi
Copy link
Member

KoBeWi commented Nov 23, 2022

  1. The project settings from the editor section should be moved to Editor Settings, but with the ability to override them for the project.

This will be possible after #69012

  1. I found that doc generation does not work for all project settings. It depends on the file where the setting is defined with GLOBAL_DEF:

Ideally we should move all setting definitions to one place. See godotengine/godot-proposals#4771

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by production team.

@YuriSizov YuriSizov merged commit fab9926 into godotengine:master Jan 24, 2023
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants