Add support for scene/resource customization in export plugins #65135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
force-pushed
the
export-customization-plugins
branch
2 times, most recently
from
92ea01b
to
d6317d1
Compare
reduz
force-pushed
the
export-customization-plugins
branch
from
d6317d1
to
c91072b
Compare
reduz
force-pushed
the
export-customization-plugins
branch
2 times, most recently
from
9745534
to
bfc8a7f
Compare
|
This should be good now (tested it locally). |
akien-mga
requested changes
Sep 1, 2022
reduz
force-pushed
the
export-customization-plugins
branch
from
bfc8a7f
to
c20f54b
Compare
EditorExportPlugin adds a set of callbacks to allow customizing scenes, resources or subresources in all files exported: * Can take scene files, resource files and subresources in all of them. * Uses a cache for the converted files if nothing changes, so this work only happens if a file is modified. * Uses hashing to differentiate export configuration caches. * Removed the previous conversion code to binary, as this one uses existing stuff. This API is useful in several scenarios: * Needed by the "server" export platform to get rid of textures, meshes, audio, etc. * Needed by text to binary converters. * Needed by eventual optimizations such as shader precompiling on export, mesh merging and optimization, etc. This is a draft, feedback is very welcome.
reduz
force-pushed
the
export-customization-plugins
branch
from
c20f54b
to
ef17c46
Compare
|
Thanks! |
|
This causes #56343 for all scene preloads. |
|
Will this be backported to 3.x? |
This relies on a lot of core refactoring done in 4.0 (most of which is backwards-incompatible), so no. This would need to be redone from scratch by a motivated contributor, and even then, it's not guaranteed to be merged for 3.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorExportPlugin adds a set of callbacks to allow customizing scenes, resources or subresources in all files exported:
This API is useful in several scenarios:
Obligatory screenshot of API:
This is a draft, feedback is very welcome.. Should be ready for review now.