Fix drag'n drop type checking for NodePaths #62692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solution doesn't allow using sub-classes, which is a valid use-case and should be supported. |
This comment was marked as outdated.
This comment was marked as outdated.
Nolkaloid
force-pushed
the
typesafe-nodepath-dnd
branch
from
db18dbb
to
698d629
Compare
|
Updated! It should work for sub-classes now :) |
KoBeWi
reviewed
Jul 4, 2022
Nolkaloid
force-pushed
the
typesafe-nodepath-dnd
branch
2 times, most recently
from
477f395
to
a4ccc5e
Compare
KoBeWi
reviewed
Jul 4, 2022
KoBeWi
approved these changes
Jul 4, 2022
Nolkaloid
force-pushed
the
typesafe-nodepath-dnd
branch
from
a4ccc5e
to
31745a8
Compare
|
Thanks! |
|
This actually breaks the following code: @export var n: NodePathNo node can be dropped to a generic NodePath variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62691