Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix computation of screen_uv #61070

Merged
merged 1 commit into from
May 16, 2022
Merged

Fix computation of screen_uv #61070

merged 1 commit into from
May 16, 2022

Conversation

somnathsarkar
Copy link
Contributor

@somnathsarkar somnathsarkar commented May 16, 2022 •
edited by akien-mga
Loading

screen_uv does not need to account for the center of a pixel since gl_FragCoord returns pixel center by default. Incorrect values of screen_uv cause artifacts at the borders of objects when the wrong texel is fetched.

@somnathsarkar somnathsarkar requested a review from a team as a code owner May 16, 2022 00:24
@Calinou Calinou added this to the 4.0 milestone May 16, 2022
Calinou
Calinou approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 396def9 into godotengine:master May 16, 2022
This was referenced May 16, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.0
3 participants
@somnathsarkar @Calinou @clayjohn