Allow picking similar colours using OKHSL.

[fire]

Fixes: godotengine/godot-proposals#4325

Pain points requested for help:

• get_ok_hsl_h naming in Color
• Default pickers
• How to cite code? for shaders
• NOT Adding it to the Gradient

2022-04-01.05-11-46.mp4

HSL Game Project.zip test project.

[fire]

@gongpha Touched the picker color interface and @clayjohn can be good to review shaders.

Can you check?

[YeldhamDev]

I wonder if it wouldn't be better if an OptionButton was used instead of two CheckButtons.

[KoBeWi]

I wonder if it wouldn't be better if an OptionButton was used instead of two CheckButtons.

I was planning to refactor the ColorPicker, because the color modes are awfully hard-coded right now; I might do it eventually™. Somewhat related issue: #31679

[fire]

@YeldhamDev if you can send a commit, I can integrate it.

[clayjohn]

I think if we add OKHSL to the colour picker, we should also be adding it to the GradientTexture2D. To me, the real benefit of OKLab is interpolating colours in perceptually uniform space. I think users will be disappointed if they are selecting colours in OKLab, but the colours are interpolated in RGB or HSL.

[fire-forge]

I think if we add OKHSL to the colour picker, we should also be adding it to the GradientTexture2D.

Or it could be added to Gradient, so that everywhere that Gradients are used benefits from it (GradientTexture2D/1D, particles, FastNoiseLite, etc.)

[clayjohn]

I think if we add OKHSL to the colour picker, we should also be adding it to the GradientTexture2D.

Or it could be added to Gradient, so that everywhere that Gradients are used benefits from it (GradientTexture2D/1D, particles, FastNoiseLite, etc.)

Yes, that makes much more sense.

[fire]

@clayjohn @fire-forge

Or it could be added to Gradient, so that everywhere that Gradients are used benefits from it (GradientTexture2D/1D, particles, FastNoiseLite, etc.)

Can you guys assist adding to a Gradient after the pr is merged?

[clayjohn]

If we are adding OKLab, I think it should be added to gradient at the same time it is added to the color picker. I don't see the value in just exposing it to the color picker. But, of course, let me know if I am wrong.

[fire-forge]

@fire The Gradient changes look good, I haven't tested them yet but I will soon. Also, I noticed that the OKHSL-related Color functions don't seem to be exposed, so maybe you could do that? It could be useful to have access to them in GDScript.

[fire]

@clayjohn I don't think it's really possible to interpolate all three variables: the hue, the lightness and the saturation. We have to keep one constant and a small change in hues is a big change in HSL space. Interpolating in RGB and then using okhsl lightness and okhsl saturation didn't give good results.

https://stackoverflow.com/a/7391704/381724

[fire]

I'll merge the kobewi change properly.

[KoBeWi]

btw you have me added as a co-author of the commit (probably from applying suggestion on GitHub).

[akien-mga]

Looks good to me overall. Would be nice if @Vitika9 could review too as that will impact her GSoC project.

[VitikaSoni]

Looks good to me overall. Would be nice if @Vitika9 could review too as that will impact her GSoC project.

Looks good from my project's point of view too :)

[akien-mga]

Thanks!