Deleting only repeating "Scripted Variables" props

[object71]

Fixes #58239
Fixes #43491
Fixes #54410

As described in the linked issue more properties were deleted from the initial "Scripted Variables" section than needed. My changes will perserve additional properties defined in _get_property_list but it won't categorize them properly when a few user scripts are extended.

Bugsquad edit: Also fixes #63454

[TheSecondReal0]

This is an absolute life saver! I'd just finished porting my project to 4.0 alpha 3 to find that all of my custom exports were broken and this PR fixed it. I've been using the build artifact ever since and everything seems to be working as expected even when I'm doing some weird stuff with inherited custom classes.

[object71]

btw do i need to do something for a PR to get reviewed?

[Calinou]

btw do i need to do something for a PR to get reviewed?

No, but since there is a lot of backlog for reviewing PRs, it may take a while for this PR to be merged. Sorry for the inconvenience.

[object71]

btw do i need to do something for a PR to get reviewed?

No, but since there is a lot of backlog for reviewing PRs, it may take a while for this PR to be merged. Sorry for the inconvenience.

Thanks, there is no inconvenience.

[reduz]

@vnen It looks like this is something that happened apparently as a change to GDScript so I am unsure if it needs to be fixed in the inspector. Let me know when you have time to lend me a hand understanding it.

[object71]

Indeed the problem is that get_script_property_list on line 3609 doesn't produce all the properties that are related to a single script (the missing ones are the ones defined by the user in gdscript but not through the export keyword. My solution on the other hand solves the problem by not deleting any properties that couldn't be categorized which is somewhere to start from and would solve the general issue and any further issues of this kind.

It is still better to not be trigger-happy with the deleting of properties and then solve the problem of them not being categorized in the proper script.

[YuriSizov]

So while investigating #63454 I've run into issues with code from #32428 as well, came to the same conclusions, and that in turn led me here. It's a very weird solution, originally, to remove everything from the bottom item until the next category. It doesn't support _get_property_list for some reason (might be a GDScript module issue), and it doesn't work with the new grouping annotations.

This PR seems to fix #63454 and it works correctly with the issues it was set to fix, according to my limited testing. I'm going to approve it, as the code and the approach makes more sense to me than what we have right now. But I think this piece of code, the entire _update_script_class_properties method, is problematic. Even if there are issues on the GDScript side, it's in need of fixing in the inspector as well.

[akien-mga]

Thanks!

[reduz]

I have no problem in merging this, but it should have comments of what it fixes and why because its basically a hack.