In final phase of test_body_motion, move and cull AABB for body once instead of for every shape #58287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As briefly discussed on RocketChat, two lines (moving
body_aabband calling_cull_aabb_for_body) were moved into a loop over shapes in 66c6dfb for 2D and (for consistency?) in #46148 for 3D. This PR moves those lines back to their original position, where they likely belong, as "repeatedly moving the AABB, once for each shape" does not seem to be logical.There are no regressions when running the test projects from #16250, #35945 (comment), #45971, #45971 (comment), #46134 (after updating them to run under
master). With more effort, more of the test projects linked in #46148 could be tested.