Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 2D editor's right-click menu #56881

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 17, 2022

  • adds "Paste Node(s) Here" option (originally requested here)
    • available only if there is at least 1 CanvasItem in node clipboard
  • adds "Move Node(s) Here" option (I vaguely remember someone mentioning it; the dialog is small anyways, so adding more actions won't hurt)
    • available only if there is at least 1 CanvasItem currently selected
  • renames "Instance Scene Here" to "Instantiate Scene Here"
    godot windows tools 64_vZpnTBzyCn

Putting as draft for now, because global positions don't work correctly.

btw apparently we don't have Paste and Move icons (unless they are named differently), so the new options have no icon. Suggestions for icons appreciated.

@Mickeon
Copy link
Contributor

Mickeon commented Jan 18, 2022

Could ActionPaste.svg be used for "Paste Node(s) Here"?

Also, perhaps the icon of the Move Tool could be used for "Move Node(s) Here", since... it does what it does.

@fire-forge
Copy link
Contributor

Could "Paste/Move Node(s) Here" be changed to use "Node" and "Nodes" depending on whether multiple nodes are selected instead of just putting "(s)" on the end? This would probably also require adding two different translations so it could be done for other languages as well.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 18, 2022

Ok added the new icons:
image

Could "Paste/Move Node(s) Here" be changed to use "Node" and "Nodes" depending on whether multiple nodes are selected instead of just putting "(s)" on the end?

It could, but we don't do that anywhere in the editor, so actually no.

@aaronfranke aaronfranke changed the title Improve 2D edtior's right-click menu Improve 2D editor's right-click menu Jan 18, 2022
@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 18, 2022

I managed to fix the global positions, but I got too derailed into improving paste behavior, so I decided to move it into a separate PR: #56906
It needs to be merged before this one (right now this won't compile)

@KoBeWi KoBeWi marked this pull request as ready for review January 18, 2022 20:33
@KoBeWi KoBeWi requested a review from a team as a code owner January 18, 2022 20:33
@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 27, 2022

Rebased and simplified the code. I also fixed node positions being not precise.

@akien-mga akien-mga merged commit b7127a1 into godotengine:master Jan 27, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the get_over_here branch January 27, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants