Fix secondary handles in editor gizmos #56692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 11, 2022
| @@ -12,8 +12,9 @@ | |||
| <method name="_commit_handle" qualifiers="virtual"> | |||
| <return type="void" /> | |||
| <argument index="0" name="id" type="int" /> | |||
| <argument index="1" name="restore" type="Variant" /> | |||
| <argument index="2" name="cancel" type="bool" /> | |||
| <argument index="1" name="secondary" type="bool" /> | |||
There was a problem hiding this comment.
Some docs should be added to define what secondary means in these methods. Not sure if it should be repeated in all methods but it should at least be described once so that users know what to make of it.
JFonS
force-pushed
the
fix_gizmo_secondary_handles
branch
from
ae02753
to
db73791
Compare
|
I force-pushed some documentation notes on secondary handles. |
akien-mga
approved these changes
Jan 12, 2022
Primary and secondary handles are no longer differentiated by their ids, so a bool was added to tell them apart in all the handle-related methods. Includes a minor fix in CollisionPolygon3DEditor, unrelated to editor gizmos.
JFonS
force-pushed
the
fix_gizmo_secondary_handles
branch
from
db73791
to
5ebea2d
Compare
|
Docs should be fixed now :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary and secondary handles are no longer differentiated by their IDs, so a bool was added to tell them apart in all the handle-related methods.
Fixes #52568.