Increase joystick max button number and fix crash. #56666

bruvzg · 2022-01-10T11:52:51Z

Notes:

macOS joystick API do not have a defined button/axis limit.
Linux apparently is limited to 80 (see this kernel patch for 104 button device).
It's unlikely any device will have more buttons than supported on Windows.

doc/classes/@GlobalScope.xml

… to 128 (max. buttons supported by DirectInput).

akien-mga · 2022-01-10T15:22:50Z

Thanks!

akien-mga · 2022-01-12T15:29:11Z

Cherry-picked for 3.5.

akien-mga · 2022-01-12T15:29:31Z

Cherry-picked for 3.4.3.

bruvzg added bug topic:porting topic:input crash labels Jan 10, 2022

bruvzg added this to the 4.0 milestone Jan 10, 2022

bruvzg requested review from a team as code owners January 10, 2022 11:52

akien-mga added cherrypick:3.4 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jan 10, 2022

akien-mga reviewed Jan 10, 2022

View reviewed changes

doc/classes/@GlobalScope.xml Outdated Show resolved Hide resolved

akien-mga approved these changes Jan 10, 2022

View reviewed changes

Add joystick button index boundary check. Increase max. button number…

61ea8f8

… to 128 (max. buttons supported by DirectInput).

bruvzg force-pushed the joy_button_fix branch from 1327175 to 61ea8f8 Compare January 10, 2022 12:39

akien-mga approved these changes Jan 10, 2022

View reviewed changes

akien-mga merged commit e6cc0ff into godotengine:master Jan 10, 2022

bruvzg deleted the joy_button_fix branch January 10, 2022 16:18

akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 12, 2022

akien-mga removed the cherrypick:3.4 label Jan 12, 2022

akien-mga changed the title ~~Increase joystick button button number and fix crash.~~ Increase joystick max button number and fix crash. Jan 13, 2022

Provide feedback