Use tooltips instead of labels for VoxelGI and GPUParticlesCollisionSDF #55649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue with labels being cut off (or becoming too long when not clipped). This also adds a mention of the individual cell size, which is useful information to have when trying to avoid light leaking or particle collision tunneling.
akien-mga
approved these changes
Dec 5, 2021
|
Thanks! |
Calinou
deleted the
editor-voxelgi-gpuparticlescollisionsdf-use-info-tooltips
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with labels being cut off (or becoming too long when not clipped).
This also adds a mention of the individual cell size, which is useful information to have when trying to avoid light leaking or particle collision tunneling.
The indicative GPUParticlesCollisionSDF video RAM thresholds were also divided by two. This is because particle collision should arguably be using less VRAM than VoxelGI, since particle collision is a less "important" visual feature. (See also #55641.)
This closes #53529.
Preview
VoxelGI
Extents are (500, 64, 500).
GPUParticlesCollisionSDF
Extents are (20, 7, 20).