-
-
Notifications
You must be signed in to change notification settings - Fork 21k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method to get TileData from a cell #54549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
fastcells
branch
2 times, most recently
from
May 26, 2022 23:33
77475c3
to
852195c
Compare
groud
reviewed
Jul 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that helper makes sense as used often. Maybe yous could add a comment stating this is a helper method, not an accessor vital to TileMap good functioning?
KoBeWi
force-pushed
the
fastcells
branch
2 times, most recently
from
July 29, 2022 22:47
db4a3ac
to
cd8fb5f
Compare
Rebased. I removed the |
groud
approved these changes
Aug 22, 2022
YuriSizov
approved these changes
Aug 22, 2022
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So recently I tried the custom data in TileSets and discovered that to get custom data you need to do
That's a lot of writing for something so basic (and this snippet won't even work in all cases). So this PR adds a helper method to get the data easier.
Also it fixes
use_proxies
not defaulting to false as they should be.