Expose String.get_slice #54453
Merged
Expose String.get_slice #54453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
added
enhancement
topic:core
cherrypick:3.x
akien-mga
reviewed
Nov 1, 2021
akien-mga
approved these changes
Nov 1, 2021
mhilbrunner
approved these changes
Nov 2, 2021
KoBeWi
force-pushed
the
slice_of_string
branch
from
cfa1f2c
to
e5725c7
Compare
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use this method today and was actually surprised it's not exposed.
Although maybe it's not that useful outside core? 🤔 idk, already made a PR