Script interface improvements for test body motion #53280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouleyKetchoupp
force-pushed
the
test-body-motion-parameters
branch
2 times, most recently
from
cc8d93d
to
6c1a50b
Compare
fabriceci
approved these changes
Oct 3, 2021
Yeah, it's a good idea to do that for the most used parameters, I'll add it tomorrow. |
-Physics servers test body motion use a class to hold parameters instead of multiple arguments to make it more readable and flexible since there are many options -Improved documentation for test body motion and kinematic collision -Removed read-only properties for body motion results (not handled in scripts, so they should be get_ methods only instead)
pouleyKetchoupp
force-pushed
the
test-body-motion-parameters
branch
from
6c1a50b
to
3ae5687
Compare
Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General API and doc improvements for body motion in 2D and 3D physics servers.
List of changes:
-Physics servers test body motion use a class to hold parameters instead of multiple arguments to make it more readable and flexible since there are many options:
PhysicsTestMotionParameters-Improved documentation for
PhysicsTestMotionResultandKinematicCollision-Removed read-only properties in
PhysicsTestMotionResultandKinematicCollision(not handled in scripts, so they should be get_ methods only instead)