[WIP] Fixed Timestep Interpolation (3D) - version four #53137
Conversation
Adds fixed timestep interpolation to the visual server.
lawnjelly
changed the title
There was a problem hiding this comment.
Thanks for your work @lawnjelly, i know this one is a difficult one. I'll try and spend a little time on the other PRs as well.
| if (instance->transform == p_transform) { | ||
| return; //must be checked to avoid worst evil | ||
| } | ||
| if (!Engine::get_singleton()->is_physics_interpolation_enabled() || !instance->interpolated) { |
There was a problem hiding this comment.
I commented the same in rocket chat, but would love to see any settings for interpolation not be engine/global. As reduz suggested perhaps a property on scene tree, and perhaps something gets assigned when a node is entered in that tree.
| } | ||
|
|
||
| void VisualServerScene::InterpolationData::notify_free_instance(RID p_rid) { | ||
| if (!Engine::get_singleton()->is_physics_interpolation_enabled()) { |
There was a problem hiding this comment.
Again, prev comment regarding engine setting global
| @@ -4059,6 +4307,7 @@ bool VisualServerScene::free(RID p_rid) { | |||
|
|
|||
| instance_owner.free(p_rid); | |||
| memdelete(instance); | |||
| _interpolation_data.notify_free_instance(p_rid); | |||
There was a problem hiding this comment.
these looks safe to notify after freeing the instance, but what if some one changes notify_free_instance in some unexpected fashion later on? Should not memdelete(instance); be the last operation here?
|
I'm just having a look at whether we can simply store the interpolation lists in the The only tricky bit is that the instances and cameras need quick access to the interpolation lists, for the Then you could turn on and off the global interpolation setting per scene tree (or scenario, if you weren't using a scene tree), which would hopefully deal with these use cases. EDIT: This is implemented in #52846 |
|
Closing (at least temporarily) in favour of #52846. |
Adds fixed timestep interpolation to the visual server.
Loosely based around godotengine/godot-proposals#2753
This is based on the latest suggestions from reduz. His latest suggestion is behaviour dependent on the node type, hopefully I have this correct from our last discussions:
Physics nodes
Interpolate by default (teleport when you call
set_transform, I'm assuming)Cameras
Interpolate by default, presumably do not teleport when you call
set_transform(as that would be needed to move the camera). No mechanism to call teleport yet.Other Spatials
Do not interpolate.
New node type
reduz suggested rather than allowing Spatials to turn off interpolation, we should add a new node type with the sole purpose of turning on and off interpolation. (?) Not yet implemented.
Notes
teleport().