Implement applyEdit in LSP for signal connecting [3.x] #53068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razoric480
force-pushed
the
apply-new-signal
branch
from
3939cd1
to
885d905
Compare
akien-mga
approved these changes
Sep 25, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3.x port of #50378 , since going between Godot 3.x and 4.0 involves changing the ClassDB calls and going from PoolStringArray to PackedStringArray. But there's otherwise no real change from its 4.0 cousin. (Not sure how changeable cherrypicks are, but I may as well save implementors' time by making the 3.x changes ahead of time.)
EDIT: The same issue that #53070 fixes for 4.0 was in this one, so it is now pre-fixed for 3.x.