-
-
Notifications
You must be signed in to change notification settings - Fork 21k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Listener2D
/Listener3D
to AudioListener2D
/AudioListener3D
#52751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubonnek
force-pushed
the
rename-listener-nodes
branch
from
September 16, 2021 19:35
834ceb8
to
548a66f
Compare
Rubonnek
changed the title
Renamed Listener2D/Listener3D to AudioListener2D/AudioListener3D
Rename Sep 16, 2021
Listener2D
/Listener3D
to AudioListener2D
/AudioListener3D
Rubonnek
force-pushed
the
rename-listener-nodes
branch
from
September 16, 2021 19:41
548a66f
to
a6f6753
Compare
Do the translation files ( |
Looks like there's only one msgid ""
"Returns [code]true[/code] if the listener was made current using [method "
"make_current], [code]false[/code] otherwise.\n"
"[b]Note:[/b] There may be more than one Listener3D marked as \"current\" in "
"the scene tree, but only the one that was made current last will be used." Outside of that, the rest of the references are located within comments: #: doc/classes/Listener3D.xml Are any of these changes undesired? |
It's better not to update the translations, I do that myself. |
Rubonnek
force-pushed
the
rename-listener-nodes
branch
from
September 16, 2021 21:52
a6f6753
to
f3a564f
Compare
Changes to translations dropped. |
mhilbrunner
approved these changes
Sep 16, 2021
AaronRecord
approved these changes
Sep 17, 2021
akien-mga
approved these changes
Sep 17, 2021
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
Listener2D
/Listener3D
nodes toAudioListener2D
/AudioListener3D
godot-proposals#3299This PR was achieved by running the following shell script in Linux at the root of the repository:
and
clang-format
should take care of the rest.I'm not sure if I missed anything else that needed renaming, but that doesn't seem to be the case.