[3.x] Fix 2D/3D character snap on moving platforms #51489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying the platform velocity when leaving the platform floor should be done after snapping to keep things consistent. Now it's done in both 2D and 3D, as it's already done in 2D on master.
pouleyKetchoupp
force-pushed
the
fix-moving-platform-3d-snap-3.x
branch
from
578dfdb
to
be13538
Compare
fabriceci
approved these changes
Aug 17, 2021
akien-mga
approved these changes
Aug 17, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first point from #50732 (comment) (regression from #51458) on the 3.x branch.
CC @TokageItLab
CC @fabriceci
Applying the platform velocity when leaving the platform floor should be done after snapping to keep things consistent.
Now it's done in both 2D and 3D, as it's already done in 2D on master.
Note: On the 3.x branch, 2D had the same problem as in 3D (the decision to leave the platform was done before snapping occured), but I couldn't reproduce the same slowdown that occurs in 3D. However, I've made the same change to make it safe and consistent with 3D. It doesn't seem to cause any other issue around 2D moving platforms.