Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portals - fix PVS generation and move settings #51403

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Aug 8, 2021

Fixed a bug in the complex PVS generation which was causing recursive loop, and changes the default method back to using this complex method.
Move some of the settings out of RoomManager into Project Settings.
Allow PVS generation method to be selected from Project Settings, and control PVS logging.

room_manager_cutdown
portals_project_settings

Notes

  • While initially this was a bug fix for the complex PVS generation I decided at least for the betas it would be nice to expose choosing the PVS method, and whether PVS generation logs were displayed.
  • I had another look at the properties of RoomManager and thought it might be better to move some of them (that are unlikely to change during runtime) into ProjectSettings in order to keep the RoomManager as simple as possible.
  • In most cases, users won't need to tweak these ProjectSettings anyway, so it makes sense to keep them hidden.

Fixed a bug in the complex PVS generation which was causing recursive loop.
Move some of the settings out of RoomManager into Project Settings.
Allow PVS generation method to be selected from Project Settings, and control PVS logging.
@akien-mga akien-mga merged commit 89313b9 into godotengine:3.x Aug 8, 2021
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the portals_move_settings branch August 9, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants