Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Net] Fix IP address resolution incorrectly locking the main thread. #51199

Merged
merged 1 commit into from
Aug 3, 2021

Commits on Aug 2, 2021

  1. [Net] Fix IP address resolution incorrectly locking the main thread.

    This seems to be a pretty old bug, older then originally reported (at
    least under certain circumstances).
    
    The IP singleton uses a resolve queue so developers can queue hostnames
    for resolution in a separate while keeping the main thread unlocked
    (address-resolution OS functions are blocking, and could block for a long
    time in case of network disruption).
    
    In most places though, the address resolution function was called with
    the mutex locked, causing other functions (querying status, queueing
    another hostname, ecc) to block until that resolution ended.
    
    This commit ensures that all calls to OS address resolution are done
    with the mutex unlocked.
    Faless committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    aca5540 View commit details
    Browse the repository at this point in the history