Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] GDNative stringification of uint64_t #50806

Closed
wants to merge 1 commit into from
Closed

[3.x] GDNative stringification of uint64_t #50806

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2021

This reflects some additional unimplemented functionality for stringification of uint64_t to the GDNative.

@ghost ghost self-requested a review as a code owner July 24, 2021 14:49
@ghost ghost changed the title GDNative stringification of uint64_t [3.x] GDNative stringification of uint64_t Jul 24, 2021
@Calinou Calinou added this to the 3.4 milestone Jul 24, 2021
@akien-mga akien-mga modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga
Copy link
Member

Sorry for the late review. Exposing those two makes sense, but you would also need to add them to modules/gdnative/gdnative_api.json, no?

Note that to avoid breaking compatibility, they need to be added to an extension API and not to the base one. We just added Core API 1.3 in #55826 for Godot 3.5, so you could add those two new methods there together with PoolStringArray::join.

@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 7, 2022
@akien-mga
Copy link
Member

Superseded by #63136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants