Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize NodePath update when renaming or deleting nodes in the editor #50319

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Optimize NodePath update when renaming or deleting nodes in the editor #50319

merged 1 commit into from
Jul 22, 2021

Commits on Jul 9, 2021

  1. Optimize NodePath update when renaming or deleting nodes in the editor 

    Now the process uses a Map to lookup node pointers instead of iterating
over all modified node paths in a list and comparing them for each
property to check.

The process also avoids checking properties with empty node paths and
does an early exit on deleted nodes to avoid checking the node and its
descendants.

Also made a minor change in NodePath::rel_path_to() to avoid resizing a
Vector many times for long paths (with copy-on-write each time). Now
it's down to 2 resize calls in any case.
    @pouleyKetchoupp
    pouleyKetchoupp committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    ff40c3f View commit details
    Browse the repository at this point in the history