[RichTextLabel] Fix not updating fonts when parent theme changes #49174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reparsing the bbcode content when we receieve a theme changed notification just like we already do in ENTER_TREE. Resolves godotengine#49089
NoFr1ends
changed the title
bruvzg
approved these changes
May 31, 2021
|
Thanks! |
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49089
Analog to what we're already doing in master branch since #42595 we"re now updating the
RichTextLabel items when we receive a theme changed notification.
We should also consider cherry picking this into the 3.3 branch.