Fix STL to Godot type conversion of polypartition #48921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
cherrypick:3.3
cherrypick:3.x
akien-mga
approved these changes
May 21, 2021
|
May help the crash I've experienced with it in Goost as described in #16423 (comment) and #45125 (comment). |
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.3.2. |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #48352.
iter = iter->next()to advance iterator instead of STLiter++std::set::lower_bound, Godot'sSet::lower_boundmay also returnnullptron failureThe 3.x branch uses an older version of polypartition, only the null pointer check of
lower_boundis necessary.