Fix out of sync ScriptEditor distraction mode when Separate Distraction Mode is Enabled
#48834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
added
the
cherrypick:3.x
Paulb23
reviewed
May 28, 2021
|
@Paulb23 I have had a look at those two functions and can see what you mean. Thanks for putting me in the right direction. I will rework this to be as you suggest. |
daniel-mcclintock
force-pushed
the
fix-distraction-free-state-loss
branch
from
3d2932c
to
7cefacd
Compare
|
@Paulb23 I have updated this. Let me know if I have missed anything. |
daniel-mcclintock
force-pushed
the
fix-distraction-free-state-loss
branch
from
7cefacd
to
a6b044e
Compare
Paulb23
approved these changes
Jun 8, 2021
akien-mga
reviewed
Jun 8, 2021
daniel-mcclintock
force-pushed
the
fix-distraction-free-state-loss
branch
from
a6b044e
to
45fc6c4
Compare
akien-mga
approved these changes
Jun 9, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the Script Editor's distraction state can get out of sync.
This happens when
Separate Distraction Modeis enabled, distraction-free mode is active on the Script Editor, the user switches to a 2D or 3D Scene Editor and clicks a SceneTree Node's Edit Script button.Click to see the issue in action