Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable GIProbe emission when disabled on a material #48798

Merged
merged 1 commit into from
May 18, 2021
Merged

Disable GIProbe emission when disabled on a material #48798

merged 1 commit into from
May 18, 2021

Conversation

josefkaragoli
Copy link

Fixes #48230

@josefkaragoli josefkaragoli requested a review from a team as a code owner May 17, 2021 16:28
@Calinou Calinou added this to the 3.4 milestone May 17, 2021
@clayjohn
Copy link
Member

Code looks good! I'm just going to test it out locally before approving as I haven't worked with GIProbes much.

clayjohn
clayjohn approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga merged commit 530a999 into godotengine:3.x May 18, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request May 18, 2021
Closed
@josefkaragoli josefkaragoli deleted the emission_fix branch May 18, 2021 07:39
@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@josefkaragoli @clayjohn @akien-mga @Calinou