Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Create CollisionObject debug shapes using VS #48588

Merged
merged 1 commit into from
May 9, 2021

Conversation

trollodel
Copy link
Contributor

@trollodel trollodel commented May 9, 2021

Backport of #48175.

EDIT: Does not fix #48281 because ConcavePolygonShape in 3.x doesn't emit "changed" when the faces property changes.

@trollodel trollodel requested a review from a team as a code owner May 9, 2021 15:48
@akien-mga akien-mga changed the title Create CollisionObject debug shapes using VS [3.x\ Create CollisionObject debug shapes using VS May 9, 2021
@akien-mga akien-mga changed the title [3.x\ Create CollisionObject debug shapes using VS [3.x] Create CollisionObject debug shapes using VS May 9, 2021
@akien-mga akien-mga added this to the 3.4 milestone May 9, 2021
@trollodel
Copy link
Contributor Author

@akien-mga Don't merge it immediately as I'm still testing.

@trollodel trollodel force-pushed the collisionobject3d-no-mi-3.x branch from 0b85c89 to 60ee8c9 Compare May 9, 2021 16:30
@trollodel
Copy link
Contributor Author

@akien-mga Now it is ready (sorry to make you wait).

@akien-mga akien-mga merged commit 1827767 into godotengine:3.x May 9, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

@trollodel trollodel deleted the collisionobject3d-no-mi-3.x branch May 9, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants