Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PackedDataContainer data pointer check for non nullable #48355

Merged
merged 1 commit into from
May 5, 2021

Conversation

MaxStgs
Copy link
Contributor

@MaxStgs MaxStgs commented May 1, 2021

Fixes #46019.

In this class is 4 calls of data.read - two of them has been already protected, there are two more which one now have checking.

@akien-mga
Copy link
Member

The same fix should also be done in the master branch (core/io/packed_data_container.cpp).

@akien-mga akien-mga merged commit 6194824 into godotengine:3.x May 5, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants