Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the requestLegacyExternalStorage attribute when there are no storage permissions #47954

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Disable the requestLegacyExternalStorage attribute when there are no storage permissions #47954

merged 1 commit into from
Apr 16, 2021

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 16, 2021

Fixes #47910

@m4gr3d m4gr3d added this to the 3.3 milestone Apr 16, 2021
@m4gr3d m4gr3d requested a review from a team April 16, 2021 14:05
akien-mga
akien-mga reviewed Apr 16, 2021
View reviewed changes
platform/android/export/export.cpp Outdated
@@ -768,6 +768,10 @@ class EditorExportPlatformAndroid : public EditorExportPlatform {
return OK;
}

bool _has_storage_permission(const Vector<String> &permissions) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool _has_storage_permission(const Vector<String> &permissions) {
bool _has_storage_permission(const Vector<String> &p_permissions) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

akien-mga
akien-mga reviewed Apr 16, 2021
View reviewed changes
platform/android/export/gradle_export_util.h Outdated
@@ -275,13 +275,16 @@ String _get_activity_tag(const Ref<EditorExportPreset> &p_preset) {
return manifest_activity_text;
}

String _get_application_tag(const Ref<EditorExportPreset> &p_preset) {
String _get_application_tag(const Ref<EditorExportPreset> &p_preset, bool has_storage_permission) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
String _get_application_tag(const Ref<EditorExportPreset> &p_preset, bool has_storage_permission) {
String _get_application_tag(const Ref<EditorExportPreset> &p_preset, bool p_has_storage_permission) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@m4gr3d m4gr3d force-pushed the automatically_remove_legacy_storage_attribute branch from 2b2edc1 to bc68872 Compare April 16, 2021 14:26
@akien-mga akien-mga merged commit d91c1a6 into godotengine:3.x Apr 16, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Apr 16, 2021
Closed
@anisc
Copy link

anisc commented Apr 20, 2021 •
edited
Loading

with 3.2.3, Would adding android:requestLegacyExternalStorage="false" to the android manifest under android/build in the app change anything?
My app only permission is internet and I have no idea how to fix it, by may 5th it will be pulled off the google play store if I don't find a solution.

@m4gr3d m4gr3d deleted the automatically_remove_legacy_storage_attribute branch April 21, 2021 13:26
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 21, 2021

@anisc You can add tools:remove="android:requestLegacyExternalStorage" to the manifest under android/build to remove it.
Here's the link to the full documentation.

@anisc
Copy link

anisc commented Apr 21, 2021

@m4gr3d thank you so much for returning to me.
Ok I will try it and let you know because I did try : android:requestLegacyExternalStorage="false" under but nothing changed so I will try "remove" hopefully it will work.

@yosoychiro
Copy link

yosoychiro commented Apr 28, 2021 •
edited
Loading

Hello @anisc, I have the same problem.
Did the tools:remove="android:requestLegacyExternalStorage" in the manifest work for you?
Do you happen to know if the playconsole updates you about the compliance of your app after submitting your new version?

@akien-mga
Copy link
Member

You can use Godot 3.3 and you won't need to add any workaround to the manifest: https://godotengine.org/article/godot-3-3-has-arrived

@anisc
Copy link

anisc commented Apr 28, 2021

@besyuser As @akien-mga said i'm using godot 3.3 published the game but the warning is not gone on the console, so at this point I'm just waiting and crossing my fingers.
I did speak with customer service and they said it is normal for the warning to stay as a form of "archive"... 😕😕

@yosoychiro
Copy link

Thank you guys! Yesterday I published a version with the android manifest change. And today I published another one using Godot 3.3
We should be OK then.

@madmiraal madmiraal mentioned this pull request Jun 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:buildsystem
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@m4gr3d @akien-mga @anisc @yosoychiro