Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog for Godot 3.3 #47505

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Update changelog for Godot 3.3 #47505

merged 1 commit into from
Apr 20, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 30, 2021

Note: Release date and announcement URL haven't been filled in yet.

@Calinou Calinou added this to the 3.3 milestone Mar 30, 2021
@Calinou Calinou force-pushed the update-changelog-3.3 branch 3 times, most recently from bc2b27a to cbd5575 Compare March 30, 2021 19:30
akien-mga
akien-mga reviewed Mar 31, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
akien-mga
akien-mga approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. We could merge as is, I'd add the release announcement and release date when I tag the release.

YeldhamDev
YeldhamDev requested changes Apr 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@DarkKilauea
Copy link
Contributor

You might want to mention a breaking change from 3.2.3 to 3.3:

The signature of Object _make_custom_tooltip(String) changed to Control _make_custom_tooltip(String) on Control, which will require a code change for anyone overriding that method.

@Calinou
Copy link
Member Author

Calinou commented Apr 11, 2021 •
edited
Loading

You might want to mention a breaking change from 3.2.3 to 3.3:

The signature of Object _make_custom_tooltip(String) changed to Control _make_custom_tooltip(String) on Control, which will require a code change for anyone overriding that method.

Done (see Changed > GUI).

@akien-mga akien-mga mentioned this pull request Apr 12, 2021
Closed
@Calinou Calinou mentioned this pull request Apr 14, 2021
Closed
@akien-mga akien-mga marked this pull request as ready for review April 20, 2021 10:02
@akien-mga akien-mga merged commit f4653f6 into godotengine:3.x Apr 20, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Apr 21, 2021
Merged
@Calinou Calinou deleted the update-changelog-3.3 branch August 3, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@YeldhamDev YeldhamDev YeldhamDev approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @DarkKilauea @akien-mga @YeldhamDev