Dont Change Hovering during Control Focus Events #47280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s Exit events. This is incorrect and not fully implemented, and results in inconsistency in the UI and in the hovering variable.
This was referenced Mar 23, 2021
fire
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
This makes the 3 states: hovered, not hovered, and focus (selection) better by making Hover and Focus as 2 independent mechanisms.
Edited:
Also there's a few other alternatives. https://zellwk.com/blog/style-hover-focus-active-states/
|
This probably resolves #29326 |
KoBeWi
approved these changes
Jun 8, 2021
|
I think this resolves that other issue, as well. Nice find. |
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've talked with a few people on the chat about this. @Calinou and @vnen
This PR removes the alteration of
hoveringduring Focus Enter and Focus Exit events. The alteration ofhoveringduring Focus Enter and Exit events causes inconsistency in the UI. This PR makes the Hover and Focus styles more clear in their purpose and improves the consistency of the usage of those styles.I've tested and am using this on our projects.
backport to 3.x: #47281
When a Node is focused, it renders with its Hover stylebox and its Focus stylebox. If the node is then then Hovered and UnHovered, the Hover stylebox is removed and replaced with a Normal stylebox. This is inconsistent. It is more logical and intuitive if Hover and Focus are treated as 2 independent mechanisms.
Before:
After:
Bugsquad edit: Fixes #29326.