Fix 3D scene preview generation.

[CaptainProton42]

The previous check for creating a preview image for 3D scenes erroneously evaluated to false when no actual editor feature profile was set in the editor which means no preview images for 3D scenes were created in the file system dock at all.

I fixed the check so 3D scene previews will now correctly generate when no feature profile is set.

This applies to current master as well as the current 3.x branch.

This fixes #47171.

[YuriSizov]

I'm not sure this is a good solution. As unlikely as it can be that we disable 3D by default, this check shouldn't rely on a feature being on without actually checking for it. Default profile should still be a profile.

[CaptainProton42]

Is there a proper way to check for which features are enabled by default when no profile is set?

If I understand this snippet of code correctly, the check for whether to display the 3D editor at all is done in the same way:

godot/editor/editor_node.cpp

Line 5501 in ec3f220

main_editor_buttons[EDITOR_3D]->set_visible(true);

[akien-mga]

I share @pycbouh's concern but this is better than the current status anyway, and we're unlikely to disable 3D by default in the future.

[akien-mga]

Needs a rebase, otherwise should be good to merge.

[CaptainProton42]

I share @pycbouh's concern but this is better than the current status anyway, and we're unlikely to disable 3D by default in the future.

I also agree, but I don't see another way of doing this right now.

Anyways, I rebased on top of current master!

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.4.

[akien-mga]

Cherry-picked for 3.3.1.

[AgasferLukich]

Hello. Many thanks. Thanks to everyone who took part in solving this problem. This thing is already working in 3.3.1 rc and I am very happy.