Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing semicolons to webxr.eterns.js #46297

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

madmiraal
Copy link
Contributor

As identified by LGTM, #44154 missed some semicolons. This PR explicitly adds the implicitly added semicolons.

@madmiraal madmiraal added enhancement platform:web topic:xr cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Feb 21, 2021
@madmiraal madmiraal added this to the 4.0 milestone Feb 21, 2021
@madmiraal madmiraal requested a review from a team as a code owner February 21, 2021 19:33
@dsnopek
Copy link
Contributor

dsnopek commented Feb 21, 2021

Thanks! The missing semicolons shouldn't actually cause any problems, but it'd be better to have them there. :-)

@akien-mga akien-mga merged commit 54a1b0a into godotengine:master Feb 21, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the add-missing-semicolons branch February 22, 2021 07:01
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants